Add missing ENABLE_SPIRV_CODEGEN guards#8374
Merged
damyanp merged 2 commits intomicrosoft:mainfrom Apr 14, 2026
Merged
Conversation
The SPIR-V SampledTexture1D commit (71bf911) added case labels for AR_OBJECT_VK_SAMPLED_TEXTURE1D and AR_OBJECT_VK_SAMPLED_TEXTURE1D_ARRAY in GetBasicKindType() and DiagnoseRegisterType() without wrapping them in #ifdef ENABLE_SPIRV_CODEGEN. This causes build failures when SPIRV codegen is disabled. Co-authored-by: Copilot <[email protected]>
…iler into user/damyanp/fix-spirv-guards
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
V-FEXrt
approved these changes
Apr 14, 2026
alsepkow
approved these changes
Apr 14, 2026
tex3d
reviewed
Apr 14, 2026
| case AR_OBJECT_VK_SAMPLED_TEXTURE1D: | ||
| case AR_OBJECT_TEXTURE1D_ARRAY: | ||
| #ifdef ENABLE_SPIRV_CODEGEN | ||
| case AR_OBJECT_VK_SAMPLED_TEXTURE1D: |
Contributor
There was a problem hiding this comment.
This is fine, but in this case, there is a SPIRV block at the end of the empty fall-through case statements (L5061/R5063). It might be slightly cleaner to group these in that block.
tex3d
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AR_OBJECT_VK_* enums are only available when ENABLE_SPIRV_CODEGEN is defined.